Add NGIOT transport and SST authenticationNgiot transport auth#1569
Open
Astute4185 wants to merge 3 commits into
Open
Add NGIOT transport and SST authenticationNgiot transport auth#1569Astute4185 wants to merge 3 commits into
Astute4185 wants to merge 3 commits into
Conversation
Re-added comments removed from authenication.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the core NGIOT transport and SST authentication plumbing.
It is the first PR in a staged NGIOT implementation split. The intent is to keep the change reviewable and release-safe before adding command handling, MQTT numeric-topic routing, hardware profile support, or map support.
In scope
Out of scope
eyfj07hardware profile enablement.Overall goal
The end goal is to add support for NGIOT-based devices, including the
eyfj07printer, in a staged and reviewable way.Planned sequence:
eyfj07hardware profile without map supportRelease safety
This PR keeps
mainreleasable because it only adds internal transport/authentication plumbing.It does not expose a new hardware profile, does not route NGIOT MQTT messages, does not add NGIOT commands, and does not enable map support.
Testing
uv run --python 3.14 pytest tests/test_ngiot_client.py tests/test_sst_authentication.py tests/test_authentication_ngiot.pyuv run --python 3.14 mypy deebot_client/ngiot_client.py deebot_client/sst_authentication.py tests/test_ngiot_client.py tests/test_sst_authentication.py tests/test_authentication_ngiot.pyuv run --python 3.14 prek run ruff-check --files deebot_client/ngiot_client.py deebot_client/sst_authentication.py tests/test_ngiot_client.py tests/test_sst_authentication.py tests/test_authentication_ngiot.pyuv run --python 3.14 prek run ruff-format --files deebot_client/ngiot_client.py deebot_client/sst_authentication.py tests/test_ngiot_client.py tests/test_sst_authentication.py tests/test_authentication_ngiot.pyuv run --python 3.14 prek run --all-filesexcept unrelated existing mypy baseline failuresKnown unrelated full-prek mypy baseline failures:
tests/rs/test_map.pytests/test_mqtt_client.pytests/test_device.pytests/commands/xml/test_life_span.py